From rpgoldman at sift.info Fri Sep 18 16:28:04 2020 From: rpgoldman at sift.info (Robert Goldman) Date: Fri, 18 Sep 2020 18:28:04 -0500 Subject: [Openmcl-devel] The CCL download page needs a refresh... Message-ID: I downloaded and installed CCL for Linux from here https://github.com/Clozure/ccl/releases/download/v1.11.5/ccl-1.11.5-linuxx86.tar.gz This caused me all kinds of ASDF pain, until I went direct to GitHub. It looks like the links on this page: https://ccl.clozure.com/download.html ... which is still the main result from Googling, badly need updating. So that no one else has the same pain as I did, would someone mind updating (or removing) that page? From enometh at meer.net Sat Sep 26 07:11:36 2020 From: enometh at meer.net (Madhu) Date: Sat, 26 Sep 2020 19:41:36 +0530 (IST) Subject: [Openmcl-devel] PATCH fix defsetf lambda-lists Message-ID: <20200926.194136.1174468780862808668.enometh@meer.net> Hello. There is a problem with CCL's interpretation of defsetf lambda-lists (3.4.7). The following example blows. (defvar $foo 10) (defsetf get-foo (&key (add1 1) (add2 (+ add1 2))) (data) `(setq $foo (- ,data ,add1 ,add2))) (get-setf-expansion '(get-foo)) ;; => The value #:ADD1 is not of the expected type NUMBER. (setf (get-foo) 10) ;; should return 6 Attached is a hacked up patch which attempts to fix this. It uses CCL::%DESTRUCTURE-LAMBDA-LIST instead of CCL::RENAME-LAMBDA-VARS to come up with a suitable setf expansion. There is one remaining "unhygenic" use of EXPRESSION in the code, and I haven't fixed the indentation - this is so that the changes I've made are clearly visible for inspection. I'd appreciate it if you could test and review this patch for correctness, and commit something like it---Madhu -------------- next part -------------- A non-text attachment was scrubbed... Name: fix-ccl-defsetf.patch Type: text/x-patch Size: 2924 bytes Desc: not available URL: From phoe at disroot.org Sat Sep 26 11:18:03 2020 From: phoe at disroot.org (=?UTF-8?Q?Micha=c5=82_=22phoe=22_Herda?=) Date: Sat, 26 Sep 2020 20:18:03 +0200 Subject: [Openmcl-devel] PATCH fix defsetf lambda-lists In-Reply-To: <20200926.194136.1174468780862808668.enometh@meer.net> References: <20200926.194136.1174468780862808668.enometh@meer.net> Message-ID: I'd submit to github.com/Clozure/ccl where the main bugtracker (and repository) currently resides. On 26.09.2020 16:11, Madhu wrote: > Hello. There is a problem with CCL's interpretation of defsetf > lambda-lists (3.4.7). The following example blows. > > (defvar $foo 10) > (defsetf get-foo (&key (add1 1) (add2 (+ add1 2))) > (data) > `(setq $foo (- ,data ,add1 ,add2))) > (get-setf-expansion '(get-foo)) > ;; => The value #:ADD1 is not of the expected type NUMBER. > (setf (get-foo) 10) ;; should return 6 > > Attached is a hacked up patch which attempts to fix this. It uses > CCL::%DESTRUCTURE-LAMBDA-LIST instead of CCL::RENAME-LAMBDA-VARS to > come up with a suitable setf expansion. There is one remaining > "unhygenic" use of EXPRESSION in the code, and I haven't fixed the > indentation - this is so that the changes I've made are clearly > visible for inspection. > > I'd appreciate it if you could test and review this patch for > correctness, and commit something like it---Madhu > > > _______________________________________________ > Openmcl-devel mailing list > Openmcl-devel at clozure.com > https://lists.clozure.com/mailman/listinfo/openmcl-devel -------------- next part -------------- An HTML attachment was scrubbed... URL: