<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">I see, thanks. So this is a bug in mel-base only, which relies on with-open-stream() closing the underlying streams. Still, this somewhat counterintuitive.<div class=""><br class=""></div><div class="">Best wishes,</div><div class="">Paul<br class=""><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">Am 16.03.2017 um 14:10 schrieb Stas Boukarev <<a href="mailto:stassats@gmail.com" class="">stassats@gmail.com</a>>:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Which would violate the standard, as "The effect of close on a constructed stream is to close the argument stream only. There is no effect on the constituents of composite streams."</div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Thu, Mar 16, 2017 at 3:54 PM, Paul Meurer <span dir="ltr" class=""><<a href="mailto:paul.meurer@uni.no" target="_blank" class="">paul.meurer@uni.no</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br class="">
<br class="">
there seems to be a bug in the concatenated-stream class in connection with with-open-stream().<br class="">
<br class="">
When a concatenated-stream is read from in the body of the macro, (e.g. with read-sequence()), concatenated-stream-next-<wbr class="">input-stream() is called subsequently, which removes the first stream from the concatenated-stream-streams slot, eventually emptying this slot.<br class="">
<br class="">
In its unwind-protect cleanup-form, with-open-stream() should close the stream, but there is no close method for concatenated-stream. (The superclass method on composite-stream-mixin just sets open-p to NIL.) With the concatenated-stream-streams slot being empty after an exhaustive read with e.g. read-sequence(), there is no obvious way either how the stream could be closed. The best way to solve this problem would probably be to have a copy of the stream list in an additional slot, and have close map over them when closing the concatenated-stream.<br class="">
<br class="">
This bug manifests itself e.g. in the mel-base library.<br class="">
<br class="">
My fix (in l1-streams.lisp) looks like this:<br class="">
<br class="">
(defclass concatenated-stream (composite-stream-mixin fundamental-input-stream)<br class="">
((streams :initarg :streams :accessor concatenated-stream-streams)<br class="">
(stream-list :initarg :stream-list :accessor concatenated-stream-stream-<wbr class="">list)))<br class="">
<br class="">
(defmethod close :after ((stream concatenated-stream) &key abort)<br class="">
(mapc (lambda (s) (close s :abort abort))<br class="">
(concatenated-stream-stream-<wbr class="">list stream)))<br class="">
<br class="">
(defun make-concatenated-stream (&rest streams)<br class="">
"Return a stream which takes its input from each of the streams in turn,<br class="">
going on to the next at EOF."<br class="">
(dolist (s streams (make-instance 'concatenated-stream :streams streams :stream-list streams))<br class="">
(unless (input-stream-p s)<br class="">
(error "~S is not an input stream" s))))<br class="">
<br class="">
<br class="">
Paul Meurer<br class="">
<br class="">
______________________________<wbr class="">_________________<br class="">
Openmcl-devel mailing list<br class="">
<a href="mailto:Openmcl-devel@clozure.com" class="">Openmcl-devel@clozure.com</a><br class="">
<a href="https://lists.clozure.com/mailman/listinfo/openmcl-devel" rel="noreferrer" target="_blank" class="">https://lists.clozure.com/<wbr class="">mailman/listinfo/openmcl-devel</a><br class="">
</blockquote></div><br class=""><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div class="gmail_signature" data-smartmail="gmail_signature">With best regards, Stas.</div>
</div>
</div></blockquote></div><br class=""></div><div class=""><br class=""></div></div></body></html>